NPE when header `replay-nonce` is not present

Ephenodrom / Dart-Acme-Client

ACME client written in Dart.

MIT License

3 stars 5 forks source link

NPE when header `replay-nonce` is not present #3

Closed gmpassos closed 2 years ago

gmpassos commented 3 years ago

https://github.com/Ephenodrom/Dart-Acme-Client/blob/6f909d2ee37d6d73d0f370a0652a3934a68f0035/lib/src/AcmeClient.dart#L353

This line should expect that the header replay-nonce is optional.

gmpassos commented 3 years ago

To force this error, send the contact list (email) without the mailto: prefix.

Ephenodrom commented 3 years ago

@gmpassos Thank you for the issue. The package is not yet finished and there are surely some things to do like adding revoke and account update functionality. Also the code documentation and other documentation has to be updated.

Will take a look a bit later on this issue.

gmpassos commented 3 years ago

I'm finishing a 1st version of a package that integrates shelf & letsencrypt. I will post it here soon.

gmpassos commented 3 years ago

FYI: https://pub.dev/packages/shelf_letsencrypt

Ephenodrom commented 3 years ago

An updated version 1.1.0 is available at pub.dev.