search

Ephenodrom / Dart-Basic-Utils

A dart package for many helper methods fitting common situations
MIT License
368 stars 79 forks source link

Migrate to null safety #36

Closed Anas35 closed 3 years ago

Anas35 commented 3 years ago

Some DateUtils tests failed. The test is not caused by this PR. The parsing of this string causing the Test to fail https://github.com/Ephenodrom/Dart-Basic-Utils/blob/ce38a41d074c25f777d2a0c18f30617bb587a68c/lib/src/DateUtils.dart#L330

Ephenodrom commented 3 years ago

@Anas35 This looks good so far, i will take a deeper look on monday or tuesday. I keep you updated!

Anas35 commented 3 years ago

Thanks for Head up. Feel free to take as much time as you want.

Anas35 commented 3 years ago

Some DateUtils tests failed. The test is not caused by this PR. The parsing of this string causing the Test to fail

https://github.com/Ephenodrom/Dart-Basic-Utils/blob/ce38a41d074c25f777d2a0c18f30617bb587a68c/lib/src/DateUtils.dart#L330

This test is now fixed. This test fail was caused by a weird bug. Test failed when the year is 1970 in https://github.com/Ephenodrom/Dart-Basic-Utils/blob/ce38a41d074c25f777d2a0c18f30617bb587a68c/lib/src/DateUtils.dart#L332

I can't able to reproduce it on Dartpad. As for now having a year other than 1970, its works.