Pointycastle introduced in 2.7.0 threw exception on some certs

certaintls commented 3 years ago

Before 2.7.0, these lines work:

File file = new File(cert.path); // e.g. on Android "/system/etc/security/cacerts/7892ad52.0" , the content of this file is pasted below
String certTxt = file.readAsStringSync();
List<int> certData = PemCodec(PemLabel.certificate).decode(certTxt);
String encoded = PemCodec(PemLabel.certificate).encode(certData);
X509CertificateData data = X509Utils.x509CertificateFromPem(encoded);

After 2.7.0 (e.g. 2.7.1), X509CertificateData data = X509Utils.x509CertificateFromPem(encoded); will throw exception:

The following _TypeError was thrown building Consumer<CertsModel>(dirty, dependencies: 
type 'ASN1Sequence' is not a subtype of type 'ASN1Set'

Is there anything that the application should do when upgrading to the newer versions?

Ephenodrom commented 3 years ago

Hello @certaintls, Sorry for the delay but I was finally able to fix this issue. The problem was a bug in the pointycastle package. The start position of the value bytes was not calculated in the correct way. The problem only appeard on a few certificates where the length of the value start position description was exactly 127 byte long.

Please use the latest version on pub dev 3.3.3.

certaintls commented 3 years ago

Thank you very much!

Ephenodrom / Dart-Basic-Utils

Pointycastle introduced in 2.7.0 threw exception on some certs #44