Ephenodrom / Dart-Basic-Utils

A dart package for many helper methods fitting common situations
MIT License
364 stars 77 forks source link

Add support for IPv6 addresses in SAN in X509 certificates #51

Closed odig closed 3 years ago

odig commented 3 years ago

IPv6 addresses in SAN portion of certificates are converted to IPv4 alike strings. I have changed to check if the byte array in san has 16 bytes and assume that this is an IPv6 address and generate the string accordantly.

Ephenodrom commented 3 years ago

Hello @odig Thank you for the PR, this looks good so far. Can you please add a unit test. After this i will merge the PR and create a new release in pub.dev.

odig commented 3 years ago

Hello @Ephenodrom, I have added the Test.

Ephenodrom commented 3 years ago

@odig Thanks again for the unit test. The PR is merged, will create a new version on pub.dev tomorrow!

Ephenodrom commented 3 years ago

A new version 3.6.1 is now available on pub.dev.