search

EpiData-dk / analysis

EpiData Analysis
2 stars 0 forks source link

Fix charts saved as svg #71

Closed charlesknightsbridge closed 4 months ago

charlesknightsbridge commented 5 months ago

Charts were not sized properly. Now, follow the same scheme as raster files using FGraphSize (1024 x 720)

torstenchr commented 4 months ago

This was intentionally implemented this way because I wanted to save the chart the same size as the window. But I guess that seen from a user perspective it is probably better to follow the same standard for all output types. @JLepidata do you have an opinion on this?

charlesknightsbridge commented 4 months ago

On my Mac, prior to this change, the .svg files came out at about 250 x 250 pixels and they did not scale up very well.. I don't know why.

JLepidata commented 4 months ago

Svg files should be vector graphics. Scalable Vector Graphics - Or else I do not understand SVG

Best Jens

⁣Hent BlueMail til Android ​

Den 6. maj 2024 20.29, fra 20.29, Jamie @.***> skrev:

On my Mac, prior to this change, the .svg files came out at about 250 x 250 pixels and they did not scale up very well.. I don't know why.

-- Reply to this email directly or view it on GitHub: https://github.com/EpiData-dk/analysis/pull/71#issuecomment-2096656420 You are receiving this because you were mentioned.

Message ID: @.***>

charlesknightsbridge commented 4 months ago

They are. When saving via the dialog (right-click on a chart), they look fine, since they use the chart window size. However, when saving from the command line, there is no window reference, so they don’t look right. Here’s an example that I opened with BoxySVG:

This may be because font sizes come from SET options and I have pareto set line widths appropriate for the default fonts.

On May 6, 2024, at 4:07 PM, Jens Lauritsen @.***> wrote:

Svg files should be vector graphics. Scalable Vector Graphics - Or else I do not understand SVG

Best Jens

⁣Hent BlueMail til Android ​

Den 6. maj 2024 20.29, fra 20.29, Jamie @.***> skrev:

On my Mac, prior to this change, the .svg files came out at about 250 x 250 pixels and they did not scale up very well.. I don't know why.

-- Reply to this email directly or view it on GitHub: https://github.com/EpiData-dk/analysis/pull/71#issuecomment-2096656420 You are receiving this because you were mentioned.

Message ID: @.***> — Reply to this email directly, view it on GitHub https://github.com/EpiData-dk/analysis/pull/71#issuecomment-2096816615, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGQYAET5ALQIAQIDQPW7VLZA7PI3AVCNFSM6AAAAABG7EX6UCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJWHAYTMNRRGU. You are receiving this because you authored the thread.

JLepidata commented 4 months ago

I should make a formal request, but have no system here. Excuses

If possible change import from clipboard to make string field NOT upper case. I am not sure if this is a core function

/Jens

⁣Hent BlueMail til Android ​

Den 15. maj 2024 21.01, fra 21.01, Torsten Bonde Christiansen @.***> skrev:

@torstenchr approved this pull request.

-- Reply to this email directly or view it on GitHub: https://github.com/EpiData-dk/analysis/pull/71#pullrequestreview-2058793075 You are receiving this because you were mentioned.

Message ID: @.***>