text disappears if @xml:lang in children of div[@type="edition"]

EpiDoc / EFES

EFES (EpiDoc Front End Services) is a custom and readily customizable platform for publication and search/indexing of EpiDoc files, based on the Kiln platform

Apache License 2.0

31 stars 38 forks source link

text disappears if @xml:lang in children of div[@type="edition"] #44

Open simonastoyanova opened 6 years ago

simonastoyanova commented 6 years ago

The text disappears if @xml:lang is put either on a div[@type="textpart"] or ab. I tried putting it both on div[@type="edition"] and "textpart"/ab for the experiment, and it doesn't appear. Seems like the only possibility is to have it on div[@type="edition"]. Needs fixing for cases of multiple languages in one inscription.

ajenhl commented 6 years ago

This is controlled in stylesheets/epidoc/prune-to-language.xsl, and further exceptions to the general rule should be added there. It may be that the existing template there should be changed to use xsl:copy-of to pull in all of the content regardless of language.

simonastoyanova commented 6 years ago

I changed the first line of the template to say <xsl:template priority="10" match="tei:div[@type='edition'] | tei:div[@type='textpart'] | tei:ab"> and it works. If this seems fine to people, I can commit. If you think it's neater to do xsl:copy-of, can try that too.

ajenhl commented 6 years ago

There are three considerations:

Can tei:div[@type='textpart'] or tei:ab occur in contexts outside of tei:div[@type='edition']?
Are there any other places within tei:div[@type='edition'] where a different xml:lang may be set (except on tei:foreign) and which should be displayed?
Conversely, are there any occasions in which part of a tei:div[@type='edition'] should not be displayed because it is in a different language?

If just the first has a positive answer, then you can just prepend tei:div[@type='edition']// to the two XPaths you added. If just the second has a positive answer, then the xsl:copy should be replaced by xsl:copy-of matching just on tei:div[@type='edition'].

gabrielbodard commented 6 years ago

1) Yes, occasionally. 2) Yes in theory, but I can't predict where at the moment. We can either use xsl:copy-of as you suggest, or wait until further examples arise and add them to the template as required. 3) Pretty definitely no. Any other div, yes, but edition (and descendents) no.

gabrielbodard commented 5 years ago

@simonastoyanova @ajenhl: what is the status of this ticket? Is everything working as it should be?

I was wondering if a solution might be to list the "suppressable" languages (languages of the edition, rather than of the texts) somewhere, and only supress those for i18n purposes. (I.e. a corpus might include inscriptions and parts of inscriptions in Greek, Latin, Hebrew, Old Church Slavonic, and Medieval Persian, and the edition might be bilingual in English and Russian. It is only the latter two languages that should trigger suppression/display in i18n function; all others should appear ubiquitously, whether in edition or elsewhere.)

IreneVagionakis commented 2 years ago

Another related issue is that EFES by default is not displaying the content of xml files whose <TEI> element has an @xml:lang attribute with a value different from the default language, i.e. 'en'.