search

EpiModel / ARTnet

Network and Epidemic Parameterization with the ARTnet Study Data
10 stars 5 forks source link

Update asmr #44

Closed karina-d-wallrafen closed 1 year ago

smjenness commented 1 year ago

Just FYI - all user-facing functions need to be "exported" from the package so they are accessible. With roxygen, this is what the @export tag does. When you rebuild the docs, this will update the NAMESPACE file that defines exported functions.

smjenness commented 1 year ago

For the update_asmr docs, please add an example, where you pass in some dummy data to show how to replace it. The dummy data can be generated parsimoniously with runif to generate a bunch of random numbers between 0 and 1. The key thing is that you demonstrate the needed input data structure. Thanks!

smjenness commented 1 year ago

@karina-d-wallrafen : It looks like this is good to go for now, and I could actually use the work you've done here on branch I am working on, so I am going to merge in to main now. If there are additional edits, please feel free to open a new branch and PR from main to continue. Thanks!