EpiModel / CombPrevNet

The Role of HIV Partner Services in the Modern Biomedical HIV Prevention Era
GNU General Public License v3.0
2 stars 0 forks source link

Rework truncate.plist param so that it accepts a numerical input #44

Closed smjenness closed 3 years ago

smjenness commented 4 years ago

Instead of TRUE/FALSE, it would retain all partnerships that have stopped within X number of time steps. For example, if X was 12, then we would keep all active partnerships and those that have ended within the past 12 time steps. This will improve model efficiency.

andsv2 commented 4 years ago

@smjenness for this would this supercede or compliment part.X.window parameter (part.X.window would at minimum be dependent on truncate.plist)?

EDIT: I believe the two parameters should work as such:

smjenness commented 4 years ago

Yes, there is a logical relation between these parameters, but you do not need to impose a restriction on the truncate.plist parameter in the code (this truncate.plist functionality may be used outside of the partner notification model we are building right now). So truncate.plist would neither supersede nor compliment (in the specific way that you have described above) part.X.window. Please verify this makes sense here, and then implement it.

andsv2 commented 4 years ago

Yes that makes sense; the above would have been too restrictive. And thinking on it it isn't needed as a part.X.window greater than truncate.plist would just be default pulling everyone which is fine. Apologies for confusion.

smjenness commented 3 years ago

Closed with EpiModel/EpiModelHIV-p#38