search

EpicCash / epic

Blockchain Node Server with integrated Stratum Mining Server
https://epiccash.com
Apache License 2.0
24 stars 36 forks source link

Endless try to send message buffer to peer without ban. #97

Open johanneshahn opened 11 months ago

johanneshahn commented 11 months ago

There is an issue where a peer is not banned if peer is connected but does not respond This will end in an endless send loop without dropping connection.

The log is flooded.

20230723 11:56:55.742 DEBUG epic_servers::common::adapters - locator: [2ab276c8c76f, eeae4f6cf943, ff0272d3e56b, 9e5676fb09f2, e333001f5356, 1a4ab2b96783, d4e88c3fee9c, 4453012fa00c, 60b258137731, 5cc719b6aad7, bbb772d9c324, 23d3e3266a29, ce4d1ef35287, 37b72ba630f0, 1bc77c085a4b, 439210380238, 8b1dbdbdc148, 09a1c5ede5d7, 2f0531da4d2a, 454018a56d86] 20230723 11:56:55.742 DEBUG epic_servers::common::adapters - Locate headers with offset request: 0 20230723 11:56:55.744 DEBUG epic_servers::common::adapters - returning headers: 512 20230723 11:56:55.759 DEBUG epic_servers::common::adapters - locator: [2ab276c8c76f, eeae4f6cf943, ff0272d3e56b, 9e5676fb09f2, e333001f5356, 1a4ab2b96783, d4e88c3fee9c, 4453012fa00c, 60b258137731, 5cc719b6aad7, bbb772d9c324, 23d3e3266a29, ce4d1ef35287, 37b72ba630f0, 1bc77c085a4b, 439210380238, 8b1dbdbdc148, 09a1c5ede5d7, 2f0531da4d2a, 454018a56d86] 20230723 11:56:55.759 DEBUG epic_servers::common::adapters - Locate headers with offset request: 0 20230723 11:56:55.762 DEBUG epic_servers::common::adapters - returning headers: 512 20230723 11:56:55.801 DEBUG epic_p2p::protocol - handle_payload: received block: msg_len: 1215 20230723 11:56:55.818 DEBUG epic_servers::common::adapters - locator: [2ab276c8c76f, eeae4f6cf943, ff0272d3e56b, 9e5676fb09f2, e333001f5356, 1a4ab2b96783, d4e88c3fee9c, 4453012fa00c, 60b258137731, 5cc719b6aad7, bbb772d9c324, 23d3e3266a29, ce4d1ef35287, 37b72ba630f0, 1bc77c085a4b, 439210380238, 8b1dbdbdc148, 09a1c5ede5d7, 2f0531da4d2a, 454018a56d86] 20230723 11:56:55.818 DEBUG epic_servers::common::adapters - Locate headers with offset request: 0 20230723 11:56:55.821 DEBUG epic_servers::common::adapters - returning headers: 512 20230723 11:56:55.822 DEBUG epic_servers::common::adapters - locator: [2ab276c8c76f, eeae4f6cf943, ff0272d3e56b, 9e5676fb09f2, e333001f5356, 1a4ab2b96783, d4e88c3fee9c, 4453012fa00c, 60b258137731, 5cc719b6aad7, bbb772d9c324, 23d3e3266a29, ce4d1ef35287, 37b72ba630f0, 1bc77c085a4b, 439210380238, 8b1dbdbdc148, 09a1c5ede5d7, 2f0531da4d2a, 454018a56d86] 20230723 11:56:55.822 DEBUG epic_servers::common::adapters - Locate headers with offset request: 0 20230723 11:56:55.825 DEBUG epic_servers::common::adapters - returning headers: 512

https://github.com/EpicCash/epic/blob/647a7b2cf28308d7d58102273087556d3bf4ae23/p2p/src/conn.rs#L197C4-L197C4

who-biz commented 11 months ago

Will look into. This seems an important fix.