search

EpicEricEE / ShopChest

ShopChest - Spigot/Bukkit Plugin
MIT License
45 stars 57 forks source link

ShopChest and ARM #300

Closed EmnichtdaYT closed 4 years ago

EmnichtdaYT commented 4 years ago

see yourself :D

https://drive.google.com/open?id=11AB4bV-v64388XyH0E5Q-kdTl4RDU3PD

EpicEricEE commented 4 years ago

Well, ShopChest can't know when a region is being reset, so I would have to add a listener for that plugin.

EmnichtdaYT commented 4 years ago

Nope. Just check if the Chest is still there before doing anything

EmnichtdaYT commented 4 years ago

You probebly have some sort of a method/function to create the armorstand and the Item above the Chest. Just Check before doing that if the Chest is still there, if it isn't just remove the shop

EpicEricEE commented 4 years ago

Ah yes that would make sense

EpicEricEE commented 4 years ago

This is probably the reason why I haven't already done that: The whole shop updating process (i.e. showing and hiding holograms) is asynchronous. Since I can't safely get a block's type asynchronously, I'd need to create a new synchronous task every time a hologram's visibility is toggled for a player, and check for any potential concurrency issues. I don't know how big of a performance impact that would have.

EmnichtdaYT commented 4 years ago

I dont really care about that, can u fix it? I really nead this fixed. You could do like a second version only for me if it is too much of a preformance problem

james090500 commented 4 years ago

I dont really care about that, can u fix it? I really nead this fixed. You could do like a second version only for me if it is too much of a preformance problem

Even though you're being extremely rude. I assume you used the ARM Bridge plugin?

https://www.spigotmc.org/resources/advancedregionmarket-shop-bridge.77484/

EmnichtdaYT commented 4 years ago

Omg!!! You are amazing