Added 1.16.4 Compatibility

EpicEricEE / ShopChest

ShopChest - Spigot/Bukkit Plugin

MIT License

45 stars 57 forks source link

Closed white-sdev closed 3 years ago

white-sdev commented 3 years ago

This might have bugs due to inability to test it thoroughly.

Fixed some Exception Handling (Throwing exceptions in those sections instead of eating them)
Removed a broken dependency and added local installation for the same.
Added logs for the problematic sections
Fixed and tested compatibility for 1.16.4 Spigot version.

mechcalvin commented 3 years ago

java newbie, how can i build jar file from this pull request?

StronglyHoldTV commented 3 years ago

java newbie, how can i build jar file from this pull request?

42atomys commented 3 years ago

hi @white-sdev , I see your PR too late, nice adds I just give my feedback to merge our PR in yours

Two points :

The broken dependency can fixed with only change the repo to new official ( Link to my PR: https://github.com/EpicEricEE/ShopChest/pull/351 )
Just in case : don't push development environnement settings to an open source repo. Use a gitignore in your local setup and dont push it or gitingore globally. Its principally to prevent a garbage of multitools file

EpicEricEE commented 3 years ago

I merged the other PR because there was a little too much going on here. Thanks nevertheless :)