EpicEricEE / ShopChest

ShopChest - Spigot/Bukkit Plugin
MIT License
45 stars 57 forks source link

Hologram was dissapered after ConcurrentModificationException throwed #376

Open ken-kentan opened 2 years ago

ken-kentan commented 2 years ago
[17:48:20] [Shop Updater/WARN]: Exception in thread "Shop Updater" java.util.ConcurrentModificationException
[17:48:20] [Shop Updater/WARN]:     at java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1013)
[17:48:20] [Shop Updater/WARN]:     at java.base/java.util.ArrayList$Itr.next(ArrayList.java:967)
[17:48:20] [Shop Updater/WARN]:     at ShopChest-1.13-SNAPSHOT.jar//de.epiceric.shopchest.nms.Hologram.togglePlayer(Hologram.java:140)
[17:48:20] [Shop Updater/WARN]:     at ShopChest-1.13-SNAPSHOT.jar//de.epiceric.shopchest.nms.Hologram.showPlayer(Hologram.java:92)
[17:48:20] [Shop Updater/WARN]:     at ShopChest-1.13-SNAPSHOT.jar//de.epiceric.shopchest.nms.Hologram.showPlayer(Hologram.java:83)
[17:48:20] [Shop Updater/WARN]:     at ShopChest-1.13-SNAPSHOT.jar//de.epiceric.shopchest.utils.ShopUtils.updateVisibleShops(ShopUtils.java:492)
[17:48:20] [Shop Updater/WARN]:     at ShopChest-1.13-SNAPSHOT.jar//de.epiceric.shopchest.utils.ShopUtils.updateShops(ShopUtils.java:419)
[17:48:20] [Shop Updater/WARN]:     at ShopChest-1.13-SNAPSHOT.jar//de.epiceric.shopchest.utils.ShopUtils.updateShops(ShopUtils.java:404)
[17:48:20] [Shop Updater/WARN]:     at ShopChest-1.13-SNAPSHOT.jar//de.epiceric.shopchest.utils.ShopUpdater.lambda$updateShops$1(ShopUpdater.java:72)
[17:48:20] [Shop Updater/WARN]:     at ShopChest-1.13-SNAPSHOT.jar//de.epiceric.shopchest.utils.ShopUpdater.lambda$start$0(ShopUpdater.java:31)
[17:48:20] [Shop Updater/WARN]:     at java.base/java.lang.Thread.run(Thread.java:831)
mrfloris commented 2 years ago

Which server engine and java version are you using?

ken-kentan commented 2 years ago

Paper 1.17.1 Java 16

mrfloris commented 2 years ago

On java 11+ to java 17 on 1.17.1, this build 104 works for me with older holographi display plugin (not the new one for 1.18) https://ci.codemc.io/job/EpicEricEE/job/ShopChest/104/

ken-kentan commented 2 years ago

Yeah. In usually, This issue isn't happen. The exception will be throwen in rare case.