EpicGames / PixelStreamingInfrastructure

Moved to: https://github.com/EpicGamesExt/PixelStreamingInfrastructure
https://github.com/EpicGamesExt/PixelStreamingInfrastructure
MIT License
551 stars 260 forks source link

fixed the error "reading handleStats of undefined" #454

Closed tingyuxuan2302 closed 10 months ago

tingyuxuan2302 commented 10 months ago

Relevant components:

Problem statement:

What problem does this PR address? I want to hide the relevant action buttons in the video stream, When I set the following parameters

const application = new Application({
    stream,
    onColorModeChanged: (isLightMode) => PixelStreamingApplicationStyles.setColorMode(isLightMode),
    settingsPanelConfig: {
      visibilityButtonConfig: {
        creationMode: 2
      }
    },
    statsPanelConfig: {
      visibilityButtonConfig: {
        creationMode: 2
      }
    },
    fullScreenControlsConfig: {
      creationMode: 2
    },
    videoQpIndicatorConfig: {
      disableIndicator: true
    }
  })

there have large error

ab09aea4b30df21f378455a09381d11

Solution

How does this PR solve the problem? Chain judgment is added

Documentation

If you added a new feature or changed an existing feature please add some documentation here.

Or better yet, link to the relevant /Docs update in your PR.

Test Plan and Compatibility

What steps have you taken to ensure this PR maintains compataibility with the existing functionality?

Or better yet, link to the unit tests that accompany this PR.

Belchy06 commented 10 months ago

Hey @tingyuxuan2302,

This bug has been handled in https://github.com/EpicGames/PixelStreamingInfrastructure/pull/455.

Cheers

tingyuxuan2302 commented 10 months ago

Hey @tingyuxuan2302,

This bug has been handled in #455.

Cheers

Hey @Belchy06 Thank you that this issue has been handled But I have a question Why didn't to merge my PR, What's wrong with my code, The latter says it doesn't comply with your PR rules I hope I can learn from you Thanks