EpicGamesExt / BlenderTools

Blender addons that improve the game development workflow between Blender and Unreal.
https://epicgamesext.github.io/BlenderTools/
MIT License
2.83k stars 64 forks source link

UE to Rigify - Improve the undo history CTRL+Z #12

Closed james-baber closed 4 years ago

james-baber commented 4 years ago

Addon: UE to Rigify Asset Type: Armatures Workflow: Switching through modes and undoing using UE to Rigify

Description: The undo history of blender needs to be saved to a dict in the tools properties and then mode changes need to be inserted into the saved history as they happen. Each time an undo event occurs, this saved dict needs to be checked and undos should not happen if the history gets undone all the way to a mode change.

tommywright commented 4 years ago

This one is driving me crazy. I instinctively hit cntrl z when I make a slight mistake and it removes the entire new template and I have to reload.

trvs2cool commented 4 years ago

I have hit this a good dozen times. This is extremely frustrating. At this point, the tool is effectively unusable as you can lose a half an hour of work by one mistaken ctrl-z. It is to the point where I had to disable the keyboard shortcut for undo.

spencer-melnick commented 4 years ago

A simple workaround for this is to avoid using undo while building/binding your rig, and make sure to save and reload the .blend file once you have the rig finalized and locked.

trvs2cool commented 4 years ago

A simple workaround for this is to avoid using undo while building/binding your rig, and make sure to save and reload the .blend file once you have the rig finalized and locked.

I believe my issue was that I was not freezing the rig. The documentation clearly mentions this step but it was very non-obvious that it was required without exacting reading of the documentation. Changing the tiny tiny freeze button to a giant button with tooltip "you must freeze before animating" would go a long way to fixing this confusion.

james-baber commented 4 years ago

Hey for anyone else that sees this here is a video that talks about freezing your rigs. We also now have the videos uploaded as playlists on youtube.

Also at some point the undos will be fixed so it doesn't undo the mode change

RiggingDojoAdmin commented 4 years ago

@james, since this happens so often, can you "Auto-freeze the rig" like locking the character in MotionBuilder? This keeps getting me over and over, I go to test something, move the control and forget.

james-baber commented 4 years ago

@RiggingDojoAdmin we are currently fixing this issue, shouldn't be too much longer before it is resolved.

ShwarzGoodman commented 4 years ago

Undo drops me to the beginning of rig creation even in freeze mode. https://youtu.be/LbaXpeYjnEg

Ubuntu 18.04.5 Blender 2.83.5

mariomusov commented 4 years ago

any progress on this one? I'm that close on putting it in production.

ShwarzGoodman commented 4 years ago

Too much time for resolve this fundamental feature... C'mon guys!

mariomusov commented 4 years ago

Yes, please!

james-baber commented 4 years ago

@tommywright @spencer-melnick @trvs2cool @RiggingDojoAdmin @ShwarzGoodman @mariomusov The latest release should fix this. Can you test and verify? Thanks! https://github.com/EpicGames/BlenderTools/releases/tag/20201103185616

mariomusov commented 4 years ago

CTRL-Z works but now I can't edit anything after I hit convert.

james-baber commented 4 years ago

@mariomusov fixed the issue you found. Here is the latest release. Let me know if this fix resolves this issue thanks https://github.com/EpicGames/BlenderTools/releases/tag/20201103224159

mariomusov commented 4 years ago

Works fine! Thanks James!

johnnytai commented 4 years ago

Does anyone have a problem opening their blender files with UE to Rigify rigs? Mine closes immediately after trying to open them.

trvs2cool commented 4 years ago

@johnnytai I continually have trouble opening saved files after converting to rigify rigs. Eventually I gave up trying and just started fresh every time I did a bit of animation work. I was only tweaking existing animations, so it was an issue for me, but if you were doing anything real, it would be a major problem.

james-baber commented 4 years ago

@johnnytai @trvs2cool I am going to go ahead and close this out. Here is a issue that will address this problem. I also posted a temporary work around for now until that issue is completed. Thanks! https://github.com/EpicGames/BlenderTools/issues/143