Send to Unreal: Extension settings aren't saved with file or settings file

EpicGamesExt / BlenderTools

Blender addons that improve the game development workflow between Blender and Unreal.

https://epicgamesext.github.io/BlenderTools/

MIT License

2.81k stars 61 forks source link

Send to Unreal: Extension settings aren't saved with file or settings file #491

Closed DanMcLaughlin closed 2 years ago

DanMcLaughlin commented 2 years ago

It looks like the Extension settings aren't being saved with core settings, in both the Blender file and the saved settings system. This is true for the built in extensions, In particular I keep having to set "Use Object Origin" and "Use Collections as Parents" which are in an extension, on restart they keeps defaulting to unset.

If its easier for this only to apply to built in extensions that's OK.

Addon: Send to Unreal
OS: Windows
Addon Version: Send to Unreal 2.1.4
Blender Version: Blender 3.X
Unreal Version: Unreal 5.x

kyleyoungblom commented 2 years ago

Any updates on this issue? It's definitely slowing things down to have to adjust export settings all the time.

DanMcLaughlin commented 2 years ago

It's also error prone as frequently people forget and do a export (which can take a while on big sets), but then discover the mistake and have to do it all over again.

Implementation wise I don't know the code, but I'd expect that you could sniff out the settings from all the extensions and put them into a scratchpad. The difficulty is in versioning, what do you do if you have a old setting that doesn't show up in the extension? What if the extension doesn't show up at all? You don't want to have a growing polluted setting pad ... I'd suggest having hard rules

If a setting is saved that isn't now in the extension then delete it
If an extension is in the scratch pad but not in the running plugin then clear it out

This should be fine and will work for plugin development, for users the extensions should be stable

james-baber commented 2 years ago

Thanks! I will look into the extension options not saving, and make sure that is covered in our tests.

Template versioning is something that I wanted to get around to. I have a place holder version 1.0 currently https://github.com/EpicGames/BlenderTools/blob/6ee65be54c3e12d696cde791534fc02a7d2d0d50/send2ue/resources/setting_templates/default.json#L73

And a todo to validate this when loading in templates https://github.com/EpicGames/BlenderTools/blob/6ee65be54c3e12d696cde791534fc02a7d2d0d50/send2ue/core/settings.py#L471

I just haven't implemented it since I have been strapped for time lately. We could move the template versioning into separate feature request.

DanMcLaughlin commented 2 years ago

The force is strong in this one …