EpicGamesExt / BlenderTools

Blender addons that improve the game development workflow between Blender and Unreal.
https://epicgamesext.github.io/BlenderTools/
MIT License
2.81k stars 61 forks source link

Send to UE: unsupported operand type(s) for +: 'set' and 'str' #565

Closed DanMcLaughlin closed 1 year ago

DanMcLaughlin commented 1 year ago

Doing an export, looks like a formatting problem for error reporting, trying to figure what the original issue is that caused this. Also looks to be something related to the new export method.

DanMcLaughlin commented 1 year ago

What do you think @james-baber, any ideas? I'm not seeing it on my side.

DanMcLaughlin commented 1 year ago

image

image

OK, looks like it's trying to send out a warning - I've gotten this warning before with the previous plugin, I think it's coming from the Tangent Space export setting - yes unsetting that and it exports properly.

So this looks like a bug with the Blender code, it's trying to warn by errors out, James do you want to submit a patch to Blender on this or how should we proceed?

DanMcLaughlin commented 1 year ago

For others having trouble, best solution is to throw a triangulate operator on there

james-baber commented 1 year ago

Hmm ok gotcha, yea the report method was monkey patched with the one in the utilities to trick the fbx module into thinking it is still an operator to minimize having to copy over all the fbx code, so that I only had to modify the functions that needed to be modified. But looks like I was missing this usage of the report method. https://github.com/EpicGames/BlenderTools/blob/8e58fff215925710762c279e87702fa82ac2cc04/send2ue/core/io/fbx.py#L516

I think the solution would be to just check if message == {'WARNING'} and print it out but don't raise an error?

https://github.com/EpicGames/BlenderTools/blob/8e58fff215925710762c279e87702fa82ac2cc04/send2ue/core/utilities.py#L1119

DanMcLaughlin commented 1 year ago

Oh OK, I see, yeah seems reasonable I think, easy to test just export ngon tangent space

james-baber commented 1 year ago

This was fixed in the latest release. Re-open if you are still experiencing issues