search

EpicKitten / PUBG-Replay-Manager

Shows undocumented information from PUBG replays, and has the ability to import and export replays
GNU General Public License v3.0
50 stars 14 forks source link

I made a logo for this program. & about license #6

Closed hjs0410hc closed 6 years ago

hjs0410hc commented 6 years ago

Well, I'm so new to Github, and I don't know where to post this. so i had to post this in issues tab again. I made a logo for this program, which helps this program not to look suspicious. take a look at this. prmlogo (original psd and png is in my PC.) prmforicon (for program ICON 512x512) If you like this and want to use this, feel free to reply, then I will bring them to you.

and i finished localizing this program for korean. during the process, I have made a information box and edited Main.cs. I don't know if this is OK. can you help me with this? I will upload the translated version. PUBG-Replay-Manager-master-KR.zip 1 (image of preview of translated version.)

snake-4 commented 6 years ago

Create an pull request? Edit: I see that you didn't made an fork of this repo. You have to fork, then you can create pull request. Edit2: This is only Korean. You removed English, this needs to be in another branch than master.

hjs0410hc commented 6 years ago

OK. I was supposed to fork the project and made another branch of it, right? I'm so new at this and it's confusing to use correctly. Thank you for the information.

snake-4 commented 6 years ago

Yes, you have to do that. And then create a pull request.

EpicKitten commented 6 years ago

I have created another branch called korean-master and committed your changes (Don't worry, I linked your profile in the commit)

So if you wanna add code or extra files without having me do it manually, Fork the project (Button up in the top right), this will give you an entire copy of the project that you can edit and do as you please. Once you wanna push the changes over to my branch, you'll make a pull request, Ill see it, and I can commit the changes to the main project.

For example, you can make a fork of the project, add the psd and ico files to both branches on your fork and then make a pull request from your fork. I'll see it and merge it with the main project,

hjs0410hc commented 6 years ago

Sorry, I saw your comment now cause I was so busy. I have totally understood what you told to me, Thank you very much! I will get the things done tomorrow.

EpicKitten commented 6 years ago

That's totally alright! :) Thank you for commenting and closing