search

EpicSquid / SuperiorShields

MIT License
8 stars 8 forks source link

Move stuff to the client side properly #1

Closed LumberWizard closed 5 years ago

LumberWizard commented 5 years ago

You also probably want to change the hurt time map to a WeakHashMap, so that random EntityPlayers don't stay there when a player changes dimensions/dies/disconnects, or so some guy on the Forge Discord says.

EpicSquid commented 5 years ago

It would be better to make this a static event handler (i.e. All the methods are static and it self registers using annotations). That way you don't have to do the sidedness check.

LumberWizard commented 5 years ago

Yes, I was just trying to make it as similar to your current code as I could. Should I change the rest of the handlers to use the annotation while I'm at it, for consistency?

EpicSquid commented 5 years ago

No, some handlers are deliberately using the static type. Can't remember which ones right now.