Unusual values for Flux Shield when using modified Integral Components

MuteTiefling commented 1 year ago

General Information

Describe the bug: While testing, I inserted Integral Components with a custom 8x modifier on them into a shield and found the values would go negative for recharge rate and delay.

x8

x4

x2

Base (stats modified by config to attempt to find a value that doesn't do this. Happens with default stats too)

To Reproduce:

Give yourself an item with increased stats /give MuteTiefling thermal:upgrade_augment_3{AugmentData:{BaseMod:8,Type:"Upgrade"}}
Insert into a Flux Shield

Expected behavior:

These values should be remaining positive, always.

Environment Versions

Mystic Mods Versions

superiorshields-1.19.2-3.0.2-all.jar

Other Versions:

Conflicting mod (if regarding mod integration):
Other mods you think could cause issues:
Forge: 43.2.13
Minecraft: 1.19.2
Modpack (if available): Enigmatica 9

Logging Information

Please Use gist, paste.ee, pastebin or some other log sharing service

Crash Report (if available):

Latest Log (if necessary):

Additional Information

Screenshots (if available):

Additional context (optional):

EpicSquid commented 1 year ago

Hmm, what integral components is that? Thermal Endergy? Certainly seems odd since I tested it with a 12x in the past and it was fine.

Definitely will check it out, that math seems super wrong.

MuteTiefling commented 1 year ago

It's custom using Thermal's tag system.

EpicSquid / SuperiorShields