search

Epiconcept-Paris / STRAP-epiuf

Utility function package for STRAP
0 stars 0 forks source link

MatchDico may be merged with checkDico #104

Open epi-gde opened 1 year ago

epi-gde commented 1 year ago 
          MatchDico works for character dico (put NA if not valid , doesn't count or print !)  , should be harmonised with checkDico

Originally posted by @epi-gde in https://github.com/Epiconcept-Paris/STRAP-epiuf/issues/101#issuecomment-1793384029

epi-gde commented 10 months ago

MatchDico was initialy used to ensure sourcefile validity. Content of one variable could be checked against a dico (a small dataset which should be read manually from an epiuf dico) and if doesn't match value is replaced by NA In my opinion this function may be obsolete now, the only advantage is that the function check for the dico and make sure that there is no difference . Checkdico function could be used during the check-process to reprot difference but doesn't change the value. We need to check if these function are used somewhere, and decide if we want to merge them

loremerdrignac commented 8 months ago

Dear @epi-gde Thank you so much for looking into this! After a brief discussion, it seems that the team uses "checkDico" preferentially and agrees to move to the obsolete functions the "matchDico" function which does not seem to be used. If this is fine by you, I will then move matchDico with the obsolete functions! Let me know if you agree :)