search

Epiconcept-Paris / STRAP-epiuf

Utility function package for STRAP
0 stars 0 forks source link

API suggestions #110

Closed loremerdrignac closed 4 months ago

loremerdrignac commented 6 months ago

Dear @EPI-JHS and @epi-gde, I hope you are well and had a wonderful Christmas! I had a quick look at the APIs functions and wanted to suggest you some minor modifications that I made in the following branch: APIs_suggestions. The main suggestion is to remove the printed messages in the console and replace them with message(), warning() or stop() messages. I hope this is fine by you! Please note that I have adapted the tests accordingly. Additionally, I was wondering if, when creating a kearing in createKeyring(), printing the password in the console was necessary or if we should omit this output. Please let me know your thoughts! Best wishes, Lore

EPI-JHS commented 6 months ago

Hello again @loremerdrignac, I've tested each of the functions in Keyring.r and also the downloadREDCap() function - all work perfectly. Thank you again for your help!

loremerdrignac commented 6 months ago

Dear both! Sorry I forgot to add a comment following our last exchangeon 4-5th January :) Since your first review James, I added more (but still minor) suggestions to the current branch to remove the API secret print call. I replaced it with simple messages. Let me know if this is fine by you!