search

Epiconcept-Paris / STRAP-epiuf

Utility function package for STRAP
0 stars 0 forks source link

Improve fillimage() function #121

Closed epi-mml closed 1 month ago

epi-mml commented 2 months ago

Add the possibility to insert an image from the R environment to the Excel file using the openXlsx::insertPlot() function

epi-gde commented 1 month ago

Few comment/help added to fillimage function, vignette example added Ready for pull request

loremerdrignac commented 1 month ago

Few comments on my side too :) Could we use this opportunity to rename in camelCase fillimage into fillImage so that it is consistent with the other epiuf function? Let me know your thoughts!

epi-gde commented 1 month ago

Could we use this opportunity to rename in camelCase fillimage into fillImage so that it is consistent with the other epiuf function?

Yes I think I have started with that but fillImage is not easy to read :( what about pasteImage ? We can keep fillimage as obsolete in case it was used somewhere

loremerdrignac commented 1 month ago

I was also thinking of "addImage" maybe more meaningful? I initially tried to keep fillimage as obsolete because the only difference between the two functions is the case, it could not work... If we change the name, then we can keep it as obsolete! :)