Epiconcept-Paris / STRAP-epiuf

Utility function package for STRAP
0 stars 0 forks source link

Apply dictionary 2023 09 18 #96

Closed epi-clz closed 8 months ago

epi-clz commented 9 months ago

Hi girls! Thank you so much for reviewing. I have made changes in the following functions: openDictionary() applyDictionary() compareDataset() I have noted that with ## PR_CLZ and ##END_PR_CLZ Let me know if anything is unclear or you need help

epi-jhd commented 9 months ago

Comments after testing the openDictionary() function (all other changes look great! )

epi-gde commented 9 months ago

I agree with Jenny, no warning is necessary if we have extra sheet or extra column as long we don't use them for dictionary

epi-clz commented 9 months ago

Hi all. In order go through Jenny's suggestions I'd like to share the workflow of the function now:

  1. Check if the essential sheets are found in the excel. Otherwise print warning.
  2. If Ok, check if all sheet are not completely blank. Otherwise print warning.
  3. If Ok, check if any of the sheets lacks of any essential column. Otherwise print warning and creates automatically the cols as blank.

If everything Ok -> runs the function with no problems If necessary, adds cols missing in the current user dictionary as blank, warning the user with a message. @epi-jhd @epi-gde @loremerdrignac

epi-jhd commented 9 months ago

Had a check and it's working like a dream :)

epi-mml commented 9 months ago

It works very well , well done Cris :)! I just have an idea/suggestion: do you think it can be useful to precise the missing sheet ? (For example, if the "actions" sheet doesn't exist, print "Sheet in XXX : actions sheets is missing".