search

Epidiah / asp

An interactive archive for the Golden Cobra Challenge.
0 stars 0 forks source link

Remove asp prefix from style links #8

Closed joevgreathead closed 1 year ago

joevgreathead commented 2 years ago

Resolves https://github.com/Epidiah/asp/issues/1

What does this do?

This just removes the asp/ prefix on the CSS links in the header of index.html in docs.

Screen Shot 2022-09-02 at 11 23 39 AM

Alternative

The other alternative is applying a root / ahead of the asp prefix as so:

Before

<link rel="stylesheet" type="text/css" href="asp/css/bootstrap.min.css">
<link href="asp/css/style.css" rel="stylesheet" type="text/css">

After

<link rel="stylesheet" type="text/css" href="/asp/css/bootstrap.min.css">
<link href="/asp/css/style.css" rel="stylesheet" type="text/css">

I went with the option to use the relative version of css/... as the path because it matches expectations of the development environment and the colocation of index.html and the css/ folder. After all, the asp/ prefix appears to be specific to the GitHub pages deployment and may not exist in other deployments of this site.

More info

It's not clear whether there is a build step/process/script which generates this index.html or if it is manually maintained. It seems manual, but please correct me if I'm wrong and if there's a different source for where this asp/ value is coming from.