search

Epidra / CasinoCraft

3 stars 3 forks source link

Left clicking on a card table with an axe crashes the game #3

Closed powmonk closed 3 years ago

powmonk commented 3 years ago

Possibly just left clicking, haven't been able to test fully.

java.lang.NoSuchMethodError: 'boolean net.minecraftforge.common.ForgeHooks.canHarvestBlock(net.minecraft.world.level.block.state.BlockState, net.minecraft.world.entity.player.Player, net.minecraft.world.level.BlockGetter, net.minecraft.core.BlockPos)' at mod.casinocraft.block.BlockCardTableBase.m5880(BlockCardTableBase.java:91) ~[CasinoCraft_1.17.1_v15.jar%2342!:1.0] at net.minecraft.world.level.block.state.BlockBehaviour$BlockStateBase.m60625(BlockBehaviour.java:512) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.server.level.ServerPlayerGameMode.m7391(ServerPlayerGameMode.java:161) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.server.network.ServerGamePacketListenerImpl.m7502(ServerGamePacketListenerImpl.java:941) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.network.protocol.game.ServerboundPlayerActionPacket.m5797(SourceFile:34) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.network.protocol.game.ServerboundPlayerActionPacket.m5797(SourceFile:8) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.network.protocol.PacketUtils.m131356(SourceFile:21) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.server.TickTask.run(SourceFile:18) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.util.thread.BlockableEventLoop.m6367(SourceFile:151) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.util.thread.ReentrantBlockableEventLoop.m6367(SourceFile:23) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.server.MinecraftServer.m6367(MinecraftServer.java:775) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.server.MinecraftServer.m6367(MinecraftServer.java:162) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.util.thread.BlockableEventLoop.m7245(SourceFile:125) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.server.MinecraftServer.m129961(MinecraftServer.java:758) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.server.MinecraftServer.m7245(MinecraftServer.java:752) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.util.thread.BlockableEventLoop.m18699(SourceFile:110) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.server.MinecraftServer.m130012(MinecraftServer.java:737) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.server.MinecraftServer.m130011(MinecraftServer.java:687) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?] at net.minecraft.server.MinecraftServer.m177918(MinecraftServer.java:258) ~[server-1.17.1-20210706.113038-srg.jar%2393!:?]

powmonk commented 3 years ago

Yeah it's just left clicking, doesn't matter what's in your hand.

powmonk commented 3 years ago

1.17 btw, the latest version on curseforge

Epidra commented 3 years ago

I'm currently quite busy, so a patch might take a while.

Flanks255 commented 3 years ago

"canHarvestBlock" changed names in 37.0.31 back in august. it is now "isCorrectToolForDrops" I could throw a PR your way with it fixed if that would make it easier.

Epidra commented 3 years ago

I do not take PRs, don't like people meddling with my code in my repo. But your comment helped fixing the crash. So, thanks.