search

Epimodev / svg-sprite-html-webpack

Webpack loader and plugin to generate a SVG sprite with <symbol> elements and inject it in html built by html-webpack-plugin
48 stars 4 forks source link

When used with webpack 4, you can see deprecation error #3

Closed Tarjei400 closed 5 years ago

Tarjei400 commented 5 years ago

This is error message displayed by webpack 4 : 

(node:79479) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead

Its coused by plugin.js : 158 in function apply.

Epimodev commented 5 years ago

Hi @Tarjei400

Thanks for this feedback. I think there is this message because I keep compatibility with webpack 3. I'll investigate deeply during next days to fix this 😀

Tarjei400 commented 5 years ago

Hey, I have a PR comming, I would appreciate if you could review it!

Epimodev commented 5 years ago

Ho nice 👍 No problem to review it today and publish update on npm as soon as possible

Tarjei400 commented 5 years ago

I tested it with webpack 4 though but should be backward compatible, I just moved some code around

Epimodev commented 5 years ago

Ok it's perfect thanks a lot. The way you fix it is pretty clean 👍 I've just push update to npm. It's version v2.1.1