Closed ryanduffing closed 3 years ago
ryanduffing
commented
3 years ago @otanum or @lonnkvist
Is this project dead, or are there plans to merge in the older PRs and continue maintenance? I see that some PRs haven't been touched in a while, and the last commit was in March of 2021.
This project is a wonderful alternative to Episerver Find and has been wonderful to work with and I'd like to see it have continued maintenance and updates.
otanum
commented
3 years ago @otanum or @lonnkvist
Is this project dead, or are there plans to merge in the older PRs and continue maintenance? I see that some PRs haven't been touched in a while, and the last commit was in March of 2021.
This project is a wonderful alternative to Episerver Find and has been wonderful to work with and I'd like to see it have continued maintenance and updates.
Project is far from dead. I have been really busy lately. I need to test these changes carefully.
One option is to create a release branch. Release branches create prerelease nugets.
ryanduffing
commented
3 years ago @otanum Do I create a release branch on my fork (since I'm not a contributor here), create a PR for it to this repo, and then a prerelease nuget will get created?
If so, I can do that and close this PR.
otanum
commented
3 years ago @ryanduffing 11.7.3.151-pre
ryanduffing
commented
3 years ago @otanum Thank you!
These are the changes I've outlined in Issue: https://github.com/Epinova/Epinova.Elasticsearch/issues/133
To summarize:
Custom fields are not being mapped properly when pulling from the returned set of search results. Complex objects don't come back at all and result in the error: Unable to cast object of type 'Newtonsoft.Json.Linq.JObject' to type 'Newtonsoft.Json.Linq.JValue. Because of this it requires developers using the library to map these custom fields on their own.
This PR will fix this and send the custom fields on the Customs dictionary as their original type.