search

Epinova / epinova-dxp-deployment

DXP deployment with Azure DevOps release tasks
MIT License
14 stars 10 forks source link

ZeroDownTime mode is providing an incorrect value when not specified #206

Closed nickginis closed 2 years ago

nickginis commented 2 years ago

When using the Deploy nuget package (Optimizely DXP) task and not selecting a ZeroDownTime the argument provided to the powershell command is "-ZeroDowntimeMode Not specified" which causes an error as "Not specified" is not a valid value.

ovelartelius commented 2 years ago

Hi @nickginis Thanks for your report. Do you have some more information about which type of agent you are using? Is there any chance that you have a log that I can look at? That would help to find the issue.

nickginis commented 2 years ago

Hey, We are using agent "windows-latest". Also, this appears to occur when you've first selected a value for ZeroDownTime such as "ReadOnly" and then change it back to a blank value. This causes the value to become "Not specified". I have attached a screenshot of what appears after changing the value back to blank.

image

nickginis commented 2 years ago

This is an example log of what occurs:

2022-02-10T02:02:13.9935086Z ##[section]Starting: Deploy NuGet package to Integration 2022-02-10T02:02:14.0120019Z ============================================================================== 2022-02-10T02:02:14.0120396Z Task : Deploy nuget package (Optimizely DXP) 2022-02-10T02:02:14.0120781Z Description : Start a deploy of a nuget package to target environment for your DXP project. (Optimizely DXP, former Episerver DXC) 2022-02-10T02:02:14.0121122Z Version : 2.1.8 2022-02-10T02:02:14.0121287Z Author : Ove Lartelius 2022-02-10T02:02:14.0121594Z Help : https://github.com/Epinova/epinova-dxp-deployment/blob/master/documentation/DeployNugetPackage.md 2022-02-10T02:02:14.0122159Z ============================================================================== 2022-02-10T02:02:14.3145004Z Using executable 'powershell.exe' 2022-02-10T02:02:14.3148773Z powershell.exe D:\a_tasks\DxpDeployNuGetPackage_2bc993e5-c27c-4a24-aeaf-0fc403debc8d\2.1.8\DeployNuGetPackage.ps1 -ClientKey REMOVED -ClientSecret *** -ProjectId REMOVED -TargetEnvironment Integration -SourceApp cms -DirectDeploy false -UseMaintenancePage false -DropPath REMOVED -Timeout 1800 -ZeroDowntimeMode Not specified 2022-02-10T02:02:14.8116243Z ##[error]D:\a_tasks\DxpDeployNuGetPackage_2bc993e5-c27c-4a24-aeaf-0fc403debc8d\2.1.8\DeployNuGetPackage.ps1 : A positional parameter cannot be found that accepts argument 'specified'.

2022-02-10T02:02:14.8132868Z ##[error]D:\a_tasks\DxpDeployNuGetPackage_2bc993e5-c27c-4a24-aeaf-0fc403debc8d\2.1.8\DeployNuGetPackage.ps1 : A positional parameter cannot be found that accepts argument 'specified'.

2022-02-10T02:02:14.8145111Z ##[error]At line:1 char:1

2022-02-10T02:02:14.8150581Z ##[error]At line:1 char:1

2022-02-10T02:02:14.8426214Z Script finished 2022-02-10T02:02:14.8498359Z ##[section]Finishing: Deploy NuGet package to Integration

ovelartelius commented 2 years ago

@nickginis Thanks! I will look in to it ASAP. I have a new version coming out soon. I will try to fix it in next version. I will give you a note when it is live

ovelartelius commented 2 years ago

Hi @nickginis v2.2.12 should solve your issue. Please try and get back to me if you still have any problem. Regards Ove

nickginis commented 2 years ago

Hey Ove,

The issue has been resolved. Thanks for the quick response!

Nick

ovelartelius commented 2 years ago

Nice! I will close this issue then.