search

EpistasisLab / Aliro

Aliro: AI-Driven Data Science
https://epistasislab.github.io/Aliro
GNU General Public License v3.0
225 stars 63 forks source link

Testing for datacard deletion #621

Closed HyunjunA closed 1 year ago

jay-m-dev commented 1 year ago

I checked out this commit got the HTTP 500 error message. These were my steps

  1. Uploaded a csv
  2. Enabled the AI button
  3. Clicked the "delete icon" while the first experiment was running
  4. the dataset was deleted by the DELETE endpoint

Step 4 means that experiments were not recognized as 'running'. Maybe there's a split second where an experiment is finished and a new experiment is about to start (at this point in time it's possible there are no 'running' experiments).

Checking if the AI button is 'on' instead of checking if experiments are 'running' may work here. But this wouldn't handle cases where an experiment is launched manually, and then the user attempts to delete the dataset.

I'm going to try checking for both (the status of the AI and if experiments are 'runing') on the DELETE endpoint.

jay-m-dev commented 1 year ago

Added a check for the recommender status in PR #622. @HyunjunA Could you please update your branch with the latest EpistasisLab/Aliro master branch so we can test this PR again?

jay-m-dev commented 1 year ago

After the update from master (commit 6b27b4e) the issue is partially resolved. The alert saying "dataset cannot be deleted" now pops up if the ai button is enabled. But still fails if an experiment is running manually. Since this PR adds frontend code and seems to work fine. I'm merging it and will troubleshoot issue #197 from master.