search

EpistasisLab / pmlb

PMLB: A large, curated repository of benchmark datasets for evaluating supervised machine learning algorithms.
https://epistasislab.github.io/pmlb/
MIT License
805 stars 135 forks source link

add filter_datasets to pmlb.py #117

Closed praneelc closed 4 years ago

praneelc commented 4 years ago

resubmitting as PR to master branch

weixuanfu commented 4 years ago

@trang1618 if contributor make a PR from a forked repo, the 1st CI check should failed (like this) maybe we should remove any git push or deploy step in CI for PR.

trangdata commented 4 years ago

if contributor make a PR from a forked repo, the 1st CI check should failed (like this) maybe we should remove any git push or deploy step in CI for PR.

There should be a way around this. The reason I wanted to generate these files in PR is to avoid adding anything straight to master without reviewing. Let's explore our options a bit...

trangdata commented 4 years ago

Another option is to trigger the build on push events of the forked repo.

trangdata commented 4 years ago

I believe this has now been fixed in #130.

@praneelc Could I ask you to re-submit this PR one more time, please? Thank you for being patient with us as we figure out the workflow.