search

EpistasisLab / scikit-rebate

A scikit-learn-compatible Python implementation of ReBATE, a suite of Relief-based feature selection algorithms for Machine Learning.
https://EpistasisLab.github.io/scikit-rebate/
MIT License
408 stars 73 forks source link

add MANIFEST.in and include_package_data #31

Closed bollwyvl closed 6 years ago

bollwyvl commented 6 years ago

Hi folks!

This little PR just ensures that the LICENSE file gets included along with the distribution. If you'd prefer just the package_data line rather than a MANIFEST.in, I can re-submit, but this seems to be the more conventional approach.

Background: working on packaging this over on conda-forge: https://github.com/conda-forge/staged-recipes/pull/4708

Of course let me know if anyone from the team would like to co-maintain: otherwise I'll be bumping versions on a best-effort basis, and always welcome a heads-up issue!

I looked into including the tests, and saw that they bring along some rather big-ish fixture data, so i didn't just drop those right in, but we'll run them, too, if you include them in your distribution!

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 70.213% when pulling 685a6c83690a53d22ac8ab3bc3c82147274a8a59 on bollwyvl:packaging-tweaks into 10ac1f47ee0a6a8fe1076ad225be7aef9437e904 on EpistasisLab:master.

rhiever commented 6 years ago

Thank you, @bollwyvl. Would be great if you could make it so any member of the EpistasisLab can also maintain the package on conda-forge.

cc @weixuanfu, wanted to bring this to your attention since (I assume) you're taking over maintenance duties for this package.

bollwyvl commented 6 years ago

Hm, I've never tried adding an org to maintainers. I could see an issue, as in the general case it might be a team that would have rights to merge a new version.

I'll try it, though, as well as adding a snapshot of who's there right now, and we'll see what goes down... forgiveness, right?