Closed rhiever closed 8 years ago
Would these be options that fall under the _dt_feature_selection method?
Nope - these will be separate functions.
On Friday, December 4, 2015, Nathan notifications@github.com wrote:
Would these be options that fall under the _dt_feature_selection method?
— Reply to this email directly or view it on GitHub https://github.com/rhiever/tpot/issues/45#issuecomment-162125985.
Randal S. Olson, Ph.D. Postdoctoral Researcher, Institute for Biomedical Informatics University of Pennsylvania
E-mail: rso@randalolson.com | Twitter: @randal_olson https://twitter.com/randal_olson http://www.randalolson.com
Right, duh, because dt stands for decision tree. These operators would then act as alternatives to _dt_feature_selection. I'd be interested in taking a stab at it tonight/this weekend.
Awesome. I'll keep an eye out for the PR!
On Friday, December 4, 2015, Nathan notifications@github.com wrote:
Right, duh, because dt stands for decision tree. These operators would then act as alternatives to _dt_feature_selection. I'd be interested in taking a stab at it tonight/this weekend.
— Reply to this email directly or view it on GitHub https://github.com/rhiever/tpot/issues/45#issuecomment-162132367.
Randal S. Olson, Ph.D. Postdoctoral Researcher, Institute for Biomedical Informatics University of Pennsylvania
E-mail: rso@randalolson.com | Twitter: @randal_olson https://twitter.com/randal_olson http://www.randalolson.com
@bartleyn, just wanted to ping you about this one to see if you're working on it. If not, I'll likely try to tackle this issue this week.
Was actually about to submit my PR -- I've gotten all four to work as additional operators, but could probably use some optimization (no caching, etc). Also could probably abstract a couple additional things.
Woohoo! :+1:
In your PR, please note what operators are slow (and how they can be optimized) and how else the code can be improved so we can file them as PRs or fix them on the spot.
Cheers!
Add more feature selection operators from sklearn: