Closed notoraptor closed 2 years ago
Is it common practice to include the whole yarn-3.1.1.cjs file in the repository or should it be kept as an external dependency?
Is it common practice to include the whole yarn-3.1.1.cjs file in the repository or should it be kept as an external dependency?
Hi @bouthilx , it seems yarn suggests to include it: https://next.yarnpkg.com/getting-started/qa#which-files-should-be-gitignored
.yarn/releases
is listed as a folder to keep, and they also say:
.yarn/plugins and .yarn/releases contain the Yarn releases used in the current repository (as defined by yarn set version). You will want to keep them versioned (this prevents potential issues if, say, two engineers use different Yarn versions with different features).
So, I guess we should keep it.
@bouthilx Updated with your suggestions
Sounds good, thanks for the clarification about yarn-3.1.1.cjs!
@bouthilx updated, now using queryByText+toBeInTheDocument
instead of getByText
. This should be more understandable.
[ copied from #3 ]
Hi @bouthilx ! This is a pull request that adds Github actions to run Javascript and ReactJS testings. CI configuration is located in file
.github/workflows/node.js.yml
.I added 2 example tests:
I also added to Github Actions CI a
ci-check
script provided by Carbon that checks file formatting, so I added a supplementary commit to fix code format.What do you think?