Epistimio / orion

Asynchronous Distributed Hyperparameter Optimization.

https://orion.readthedocs.io

Other

287 stars 52 forks source link

Add web API entry to edit trial status #1092

Closed notoraptor closed 1 year ago

notoraptor commented 1 year ago

Description

Hi @bouthilx ! This is a PR to edit trial status from web API in backend. No yet changes in dashboard.

Changes

Add web API entry to edit trial status: /trials/:experiment/:id/set-status/:status
Add doc for new web API entry
Add unit tests

Checklist

Tests

[ ] I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
[ ] All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

[ ] I have updated the relevant documentation related to my changes

Quality

[ ] I have read the CONTRIBUTING doc
[ ] My commits messages follow this format
[ ] My code follows the style guidelines ($ tox -e lint)

Further comments

Please include any additional information or comment that you feel will be helpful to the review of this pull request.

notoraptor commented 1 year ago

Hello @bouthilx ! I updated this PR:

I removed debug printing
I kept small changes that were introduced to try fixing CI failures, and I think they are still useful: all in last commit: https://github.com/Epistimio/orion/pull/1092/commits/c6bcf9648821db9f6ba908d81b4c96b33feee780

Playwright tests succeed! So I guess you can make a final review here!