Epix-Incorporated / Adonis

Roblox Server Administration System
https://adonis.dev
MIT License
303 stars 177 forks source link

Anti-Exploit Breaks Weapons #847

Closed L8X closed 11 months ago

L8X commented 2 years ago

I have a client who I am doing security for, and we've noticed with all anti-exploit components enabled (minus AntiLeak), it breaks all weapon tools.

It appears that something is either preventing the swords from dealing damage, or firing the touchinterests for the damage trigger.

Repro steps:

Copy our config (all antiexploit components minus AntiLeak must be on)

Insert a linkedsword (such as the one made by Roblox) and try damaging a fellow player, it should then fail to work.

RFC: Anyone got any ideas as to what's causing this?

github-actions[bot] commented 2 years ago

👋 Welcome! It looks like this is your first issue submission here. Please make sure you've included all necessary details in your post so we can reach a resolution as painlessly as possible! Also note that not recieving a response does not mean that your issue has been ignored!

L8X commented 2 years ago

I've looked into the components in question, and there's nothing that filters touchinterests out or prevents damage, from what I can tell, so I'm confused on this one.

chexburger commented 2 years ago

Only exploits can block a signal from being fired, and on the client. Adonis cannot block any signals. Something else in the game must be preventing it. Additionally, do not rely on Adonis for anti-exploit. Many of those pre-date when filtering was forced on games. Instead, anti-exploits should be largely done with sanity checks by the game itself. No game is the same.

L8X commented 2 years ago

Only exploits can block a signal from being fired, and on the client. Adonis cannot block any signals. Something else in the game must be preventing it. Additionally, do not rely on Adonis for anti-exploit. Many of those pre-date when filtering was forced on games. Instead, anti-exploits should be largely done with sanity checks by the game itself. No game is the same.

It's not an exploit causing it, the issue happens for everyone.

chexburger commented 2 years ago

It's not an exploit causing it, the issue happens for everyone.

Wasn't saying it was an exploit. I was saying only exploits can block it. Adonis does not block touched events and cannot block touched events. I recommend you check collision groups and whether the sword can trigger touched on them along with whether the sword and target parts have CanTouch enabled.

WaviestBalloon commented 2 years ago

I've tried replicating this issue, it will still kill the player for me. Are you running a old version of Adonis? You've described your configuration having AntiLeak, which was removed in this commit #810. (5296d86)

WaviestBalloon commented 1 year ago

I think this might be a dead Issue

ccuser44 commented 1 year ago

Can you reproduce this issue again? If so please give all debug information you can

Dimenpsyonal commented 11 months ago

This feature has been removed so