EpochModTeam / DayZ-Epoch

Experimental DayZ Mod for Arma 2
http://epochmodteam.github.io/DayZ-Epoch
226 stars 398 forks source link

Waterbottle crafting #1838

Closed schwanzkopfhegel closed 7 years ago

schwanzkopfhegel commented 7 years ago

Hey, I have found out that if you are using a fully filled boiled waterbottle for crafting, you do not get boiled water back. You only get back a x*oz filled water bottle.

AND: (I do not know if this is wanted) You can use right click option to drink out of a empty soda can (you need a watersource, like a lake to drink). This is not very realistic I think. But I don't know wether this also got fixed with https://github.com/EpochModTeam/DayZ-Epoch/commit/4d3f707417c1d69f81625c35a2db2beb8199e957

oiad commented 7 years ago

With the first part, what are you using the boiled water for crafting? (I haven't done any crafting)

i.e how would I reproduce it properly

schwanzkopfhegel commented 7 years ago

You are not forced to use boiled water for it. For example: You want to get goldbars out of goldore. You take a waterbottle and the goldore and right click on the goldore to craft it into goldbars (you need a fireplace within 3)

EDIT: I think you need a fireplace within 3 is a bit wrong (shouldnt it say 3m?) -> (I'm playing the german version)

oiad commented 7 years ago

I can't find that translation in any of the english texts, is it in german and you translated to english?

schwanzkopfhegel commented 7 years ago

Sorry my fault.

(you need a fireplace within 3)

was just for the example.. not the exact one. But I'm sure that the m after the 3 is missing.

oiad commented 7 years ago

`

Key crafting needs a fire within 3 meters. Kopieren eines Schlüssels ist nur innerhalb 3 Meter eines Feuers möglich. ` Is this the string you are referring to @schwanzkopfhegel ?
schwanzkopfhegel commented 7 years ago

Nope. I was talking about the crafting of goldbars out of Goldore.

oiad commented 7 years ago

That is the string that returns when you craft from ore to bars and not near a fire

schwanzkopfhegel commented 7 years ago

no. its the string that returns when you craft a key..

Key crafting

oiad commented 7 years ago

Yeah, I realise that, but it's the only string in the epoch stringtable that matches that

schwanzkopfhegel commented 7 years ago
    <Key ID="STR_EPOCH_PLAYER_149">
        <English>Crafting needs a %1 within %2 meters</English>
        <German>Zur Herstellung wird ein(e) %1 innerhalb von %2 benötigt.</German>

This one, I think Seems like only the german version is messed up..

oiad commented 7 years ago

Okay, that works. So what should the german string for that be, then?

schwanzkopfhegel commented 7 years ago
Zur Herstellung wird ein(e) %1 innerhalb von %2 Meter(n) benötigt.

I do not know how other stuff got solved, but I would translate it like that. Maybe @AirwavesMan could check that one? Edit: Do you know whether %2 can be = 1? If not "Metern" would be enough.

oiad commented 7 years ago

It's hard to know, so many people have done translations and some have been copied over from other translations so the context may be wrong.

I'll push changes for that localization anyway.

AirwavesMan commented 7 years ago

The translation above is correct. I will do a separate german translation for all new commits.

schwanzkopfhegel commented 7 years ago

Oh.. you was a bit too fast. I edited my post. https://github.com/EpochModTeam/DayZ-Epoch/commit/989c50b

oiad commented 7 years ago

@AirwavesMan If you could check my pull request and give me the updated translations for the ones I have updated?

AirwavesMan commented 7 years ago

Ive added the needed changes for the german strings

oiad commented 7 years ago

Thanks @AirwavesMan

schwanzkopfhegel commented 7 years ago

I have found out that if you are using a fully filled boiled waterbottle for crafting, you do not get boiled water back. You only get back a x*oz filled water bottle.

Just a small Addition/Correction: Seems like the description for a boiled x*oz waterbottle is missing.

oiad commented 7 years ago

I just spawned a water bottle (boiled) in my inventory, it has the long and short description properly showing it's boiled (there's only an ItemWaterBoiled)

edit unless you mean german?

schwanzkopfhegel commented 7 years ago

I think I did not explain it as extensivly as I should I have.. Now after you got the boiled water bottle, you need to start crafting with it. (For example craft gold ore to gold bars). After crafting you get back a 9oz waterbottle. This waterbottle isnt descriped as boiled. The crafting process destroys the boiling of the water bottle. (Atleast in the description of the waterbottle)