search

Epoxide-Software / Enchanting-Plus

The official repository for the Enchanting Plus mod.
36 stars 26 forks source link

Fix blacklist #165

Open democat3457 opened 4 years ago

democat3457 commented 4 years ago

This should fix #161 by not checking for similar NBT tags. This allows modded installs to function properly (since you can't specify NBT in the configuration file). CraftTweaker blacklist is still broken though.

democat3457 commented 4 years ago

CraftTweaker blacklist fixed in the most recent commit.

democat3457 commented 4 years ago

@Darkhax pls review

kil0byt3 commented 4 years ago

It would be great if this could get merged in, helps out a lot with modpacks (specifically Rebirth of the Night)

xJon commented 2 years ago

@democat3457 It seems that with your commit tools & armor that have been used (with durability) can still be enchanted.

democat3457 commented 2 years ago

This is good, no?

xJon commented 2 years ago

This is good, no?

This means it's still impossible to prevent Tinkers gear from being used in the Advanced Enchanting Table. It'd be preferable to be able to prevent Tinkers gear from being enchanted regardless of durability :)

democat3457 commented 2 years ago

oh i see - the blacklist currently doesn't apply to items with different durabilities. Do you know if Tinkers uses durabilities via NBT, metadata, or actual durability values?

xJon commented 2 years ago

Hmm, I don't but the mod is open source - https://github.com/SlimeKnights/TinkersConstruct/tree/1.12 Also that is the case for non tinkers items too, the blacklist only works if they haven't been used.

democat3457 commented 2 years ago

@xJon have you tried putting a wildcard meta at the end of the item in the config? or try using crafttweaker with an itemstack that has a * meta.

in any case, the most recent commit should also fix that by defaulting items without meta in the config to a wildcard meta