Epoxide-Software / EnchantingPlus

the repository for enchanting plus
11 stars 10 forks source link

Enchantment Table sliders not updating properly. #98

Closed Darkhax closed 8 years ago

Darkhax commented 8 years ago

The sliders in the table are not updating properly.This manifests itself in a range of several issues, which I will document here.

1) When you place an item in the enchantment table, it does not update the sliders, to represent existing slider positions. For example, if the item has level 2 sharpness, it will show the gui as if it has level 0 sharpness.

2) When you enchant an item, the sliders all reset to the 0 position. This causes a lot of issues, one big example is that it allows you to enchant an item with a lower level enchantment, for example if you give a sword sharpness 3, you can then enchant it again using level 2, which will override the level 3 effect with level 2.

3) This is kind of unrelated, but enchantments are being overridden. Here is a way to test, give an enchantment sharpness 1, and unbreaking 1, and then hit enchant. Then set it to give looting 3, and the sharpness 1 and unbreaking 1 will be gone. This should not happen.

4) The vertical slider is broken, very broken. If the mouse is unpressed while over an area of the screen that is NOT the vertical slider, the slider will remain in an active state, and move up and down as the mouse moves up and down.

Gif of the vertical bug

Darkhax commented 8 years ago

This issue is almost resolved, with the exception of the last issue.

Darkhax commented 8 years ago

@lclc98 This last issue still exists.

Darkhax commented 8 years ago

Successfully closed by https://github.com/Epoxide-MC/EnchantingPlus/commit/4cf0db74318f81ff393f1690c18d66bc29226cf5