search

Eppo-exp / node-server-sdk

Eppo Node.js SDK
MIT License
9 stars 0 forks source link

Include allocation key in logged event's experiment attribute (FF-851) #33

Closed sameerank closed 11 months ago

sameerank commented 11 months ago

labels: mergeable

Fixes: FF-851

Motivation and Context

Description

How has this been tested?

sameerank commented 11 months ago

Approving; although we should probably think harder about the implications of changing the Configuration Store interface since clients could be passing in their own store.

Perhaps we lave the old function names as aliases with @deprecated annotations, and then drop them with a major version bump.

Yeah, really good point. Also the name change to the client class would also necessitate code changes beyond updating the SDK to the latest. I was too focused on making this consistent with the common SDK code. I'll go back and provide both the old and new way to instantiate the client with the deprecated annotation, so future removal isn't a surprise to anyone