Epsilon99 / AestheticProgrammingCourse

0 stars 0 forks source link

Feedback on mini_ex2 by Jannik Ibsen #2

Closed JannikIbsen closed 7 years ago

JannikIbsen commented 7 years ago

To further add onto what Joachim has already mentioned, having randomness be the general theme for the entire interaction works wonders.

Not only making use of the Math.random function, "var tR = Math.floor(Math.random(tSeed) * (255 - 1 + 1)) + 1;"

but also utilizing current date/time in the syntax further adds onto the perceived goal of the project.

Making use of a switch for the shirt change was equally clever, where a unexperienced programmer would most likely just have brute forced it with if-statements.

switch(Math.floor(curMin / 10))
    {
        case 0:
            if(shirtFlag != 0)
                curShirtColor = RandomColor(curMonth);
            curLogo = img_Logo0;
            shirtFlag = 0;
            break;

Overall, a very nice and well executed take on the task at hand.