Eptagone / Vite.AspNetCore

Small library to integrate Vite into ASP.NET projects
MIT License
264 stars 35 forks source link

Version 1.9 breaks relative PackageDirectory #44

Closed Webcoda closed 1 year ago

Webcoda commented 1 year ago

You can use my repo to test

  1. Change the version of Vite.AspNetCore to 1.9.0 from 1.8.0 on UmbracoCMS\UmbracoCMS.csproj
  2. Run using dotnet run

you'll see this no package.json found error image

I believe below change breaks it

image

Eptagone commented 1 year ago

Hello. Yes, I see that there's a problem there. I'll see what i can do. But I have a question. Why do you have your assets outside the project folder?

Webcoda commented 1 year ago

I just need to separate the backend and front end folders. although the build output will be in the project folder

jdryden572 commented 1 year ago

Hi @Eptagone and @Webcoda, I also hit this issue upon upgrade because I'm keeping my Vite client app within a subfolder of my AspNetCore project. I hope you don't mind I opened a PR to address this.

Eptagone commented 1 year ago

Hi @jdryden572. It's no problem, thank you very much for fixing it. :)