search

EqualifyEverything / equalify

A web accessibility platform, managing issues by integrating with A11Y services.
https://equalify.app
Other
117 stars 21 forks source link

Incorrect Use of aria-readonly Attribute on Input Fields #353

Closed kevinandrews1 closed 4 months ago

kevinandrews1 commented 4 months ago

Went to create a report, and the report name input is using aria-readonly. This is a huge no-no. I instinctively thought for some reason I couldn’t type into it. The aria-readonly attribute semantically indicates that the element is not editable but is otherwise operable. It is, in fact, editable, so I don’t know why that’s the case as it can receive input. This issue also appears with many other inputs, such as on the “My Account” screen when updating your name, etc. need to double check text inputs and ensure this is not being incorrectly applied. this one is certainly a blocker because somebody will inaccurately think they can't type into the fields when this attribute is used.

wilsuriel03 commented 4 months ago

Complete ✅

bbertucc commented 4 months ago

@kevinandrews1 assigning this back to you to review the update.

kevinandrews1 commented 4 months ago

I get a 404 when I try to create a new report. Adding a new property there's still read only. I also observe this on my account screen. FWIW i'm in incognito as I was this morning.

kevinandrews1 commented 4 months ago

Oops, nvm, @wilsuriel03 just told me it's not in prod yet. False alarm.