search

EqualityAI / EqualityML

Evidence-based tools and community collaboration to end algorithmic bias, one data scientist at a time.
Apache License 2.0
34 stars 3 forks source link

self.threshold may mean self._threshold? #14

Closed jaared closed 1 year ago

jaared commented 1 year ago

I didn't notice self.threshold being declared. Possibly I missed it. I did see self._threshold. Is it declared someplace I missed? If not, possible typo.

https://github.com/EqualityAI/EqualityML/blob/90e04435007a653b5c4c69dc5a9b86e0c5d34ce7/equalityml/fair.py#L704-L726

JoaoGranja commented 1 year ago

threshold is a property of FAIR class with specific setter and getter methods, while self._threshold is a private member of FAIR class.