search

Equidamoid / pyconz

GNU General Public License v3.0
13 stars 4 forks source link

Change to use pyserial-asyncio instead of asyncio #7

Open Hedda opened 5 years ago

Hedda commented 5 years ago

Suggest to change import to using "pyserial-asyncio" instead of "asyncio"

https://github.com/pyserial/pyserial-asyncio

This is what zigpy-deconz is using as a depenency:

https://github.com/zigpy/zigpy-deconz

Equidamoid commented 5 years ago

Why? What are the benefits?

On Fri, 8 Mar 2019, 11:41 Hedda, notifications@github.com wrote:

Suggest to change import to using "pyserial-asyncio" instead of "asyncio"

https://github.com/pyserial/pyserial-asyncio

This is what zigpy-deconz is using as a depenency:

https://github.com/zigpy/zigpy-deconz

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Equidamoid/pyconz/issues/7, or mute the thread https://github.com/notifications/unsubscribe-auth/AARLACpRn4ZPNtOvC_2XrWCkt_xLUXDwks5vUj5ngaJpZM4blGv6 .

mfilippo commented 5 years ago

Hi,

Module serial.aio does not exist anymore. You should use pyserial-asyncio. Note that this does not imply that asyncio is no longer needed. See here.

Best,

Equidamoid commented 5 years ago

Ah, sounds reasonable.

But, is it still relevant? I mean is the lib itself used by anyone?