search

Equim-chan / mjai-reviewer

🔍🀄️ Review mahjong game log with mjai-compatible mahjong AI.
https://mjai.ekyu.moe
Apache License 2.0
1.02k stars 117 forks source link

Localize Replay Examination page #102

Closed akouryy closed 1 year ago

akouryy commented 1 year ago

Is it possible to localize https://mjai.ekyu.moe/report/***.html? Probably I can help, though it may disturb you as you'd not be able to edit English texts directly in templates/report.tera anymore.

Equim-chan commented 1 year ago

I also want to do this, but I'm not able to find a suitable i18n framework.

akouryy commented 1 year ago

How about fluent-templates? It seems nice and I'm now experimenting with it.

akouryy commented 1 year ago

It's almost done but I just found Japanese texts in old templates/report.html. What's the current state of them?

Equim-chan commented 1 year ago

They were removed from v1 but can still serve as a reference.

akouryy commented 1 year ago

Unfortunately I could not build Mortal, and my branch is only tested with akochan outputs. So I'd like to leave it to you @Equim-chan.

Equim-chan commented 1 year ago

Works for me.

Equim-chan commented 1 year ago

If you submit a pull request, I will review it.