search

Equim-chan / mjai-reviewer

🔍🀄️ Review mahjong game log with mjai-compatible mahjong AI.
https://mjai.ekyu.moe
Apache License 2.0
1.02k stars 117 forks source link

Support language setting on result page #116

Closed chucklu closed 1 year ago

chucklu commented 1 year ago

https://mjai.ekyu.moe/report/a3163d631be83983.html I would like to switch language on result page

Equim-chan commented 1 year ago

If you want a different language, you can regenerate with a different language option. I don't think it's worth adding the feature to dynamically switch the languages.

chucklu commented 1 year ago

I don't want to regenerate a new result page, that's why I mentioned this feature.

And if we support multi language on result page, then we can also make sure generate only one page for each game. Currently the site will generate a new result file every time I request an analysis

maybe we can record the site domain and source id of paipu 230919-7c027feb-1736-44c0-8a7d-847db5e3a2cb_a217782092, and avoid generate another new result file(maybe also record other unique setting) https://game.maj-soul.com/1/?paipu=230919-7c027feb-1736-44c0-8a7d-847db5e3a2cb_a217782092 https://mjai.ekyu.moe/report/a3163d631be83983.html https://mjai.ekyu.moe/report/e2ab675296cf8a6d.html

Equim-chan commented 1 year ago

That was what akochan.ekyu.moe used to do, but in mjai.ekyu.moe I decided to just use a unique ID for each result page, because it had become trivial to generate one since Mortal is fast.