Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

UI Support for CARB/US ICE v BEV and International ICE #1107

Closed ericthomasswenson closed 3 months ago

ericthomasswenson commented 2 years ago

1099 assumes the existence of a check box for CARB/US ICE to distinguish CARB (l)(1) ICE testing from alternate uses.

When CARB/US is indicated, the criteria demand one of 4 values be provided by all OBD modules, for OBD compliance.

This permits manufacturers to run tests, for international certs, without complaints that the value doesn’t meet CARB allowed numbers.

Such a box is envisioned to be selected by default, and must be deselected for International CI and SI circumstances.

ericthomasswenson commented 2 years ago

See #1101 for SOW UI needs for XEVs and BEVs

ericthomasswenson commented 2 years ago

All section 6 changes consolidated in one document.

battjt commented 2 years ago

Is the Fuel Type of "Battery/electric vehicle" sufficient? image

ericthomasswenson commented 2 years ago

1107 is about creating an escape hatch for say a Brazilian Euro VI adaption, or a China 6 off road vehicle, which won’t use 13h or 14h …

when the box is un checked failure messages for 13h 14h … are turned off.

We need to accept Bev values with the box checked

The box isn’t in the displayed content above…

ericthomasswenson commented 2 years ago

6.1.3 Provides the new criteria.

6.1.3 DM5: Diagnostic Readiness 1 6.1.3.1 Actions a. Global DM5 [send Request (PG 59904) for PG 65230 (SP 1220, OBD Compliance)]. b. Create “OBD ECU” list (comprised of all ECUs that indicate OBD compliance values other than 0, 5, FBh, FCh, FDh, FEh, or FFh for OBD compliance) for use later in the test as the “OBD ECUs.” 6.1.3.2 Fail Criteria a. Fail if no ECU reports as an OBD ECU. b. Fail if any ECU responds with a NACK (to DM5, PG 65230 request). c. Fail if a BEV vehicle response provides a value other than 1Bh (27) for OBD compliance. d. Fail if any response from a function 0 device provides OBD Compliance values of 0, 5, FBh, FCh, FDh, FEh, or FFh. e. Fail if a US/CARB vehicle does not provide OBD Compliance values of 13h, 14h, 22h, or 23h. 6.1.3.3 Warn/Info Criteria a. Warn if more than one ECU responds with a value for OBD compliance where the values are not identical (e.g., if one ECU reports 13h and another reports 22h, if one reports 13h and another reports 11h, or if one ECU reports 00h and another reports 14h). b. Warn if any response received from a non-OBD ECU provides OBD Compliance values of 0, FBh, FCh, FDh, FEh, or FFh. c. Info for DM5 replies from non-OBD ECUs. // The above changes incorporate #1099

ericthomasswenson commented 2 years ago

e. Fail if a US/CARB vehicle does not provide OBD Compliance values of 13h, 14h, 22h, or 23h.

Should perhaps have said

e. Fail if a US/CARB CI or SI vehicle does not provide OBD Compliance values of 13h, 14h, 22h, or 23h.

ericthomasswenson commented 2 years ago

8/12/2023 Task 5 Artifact Updated to

e. Fail if a vehicle with a US EPA/CARB CI or SI engine does not provide OBD Compliance values of 13h, 14h, 22h, or 23h.