search

Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

Incorrect WARN issued by v3.1.4 of test tool for Part 6.2.17.10.d #1177

Closed anthonyhbest closed 1 month ago

anthonyhbest commented 1 year ago

Tool is incorrectly implementing the warn criteria for part 6.2.17.10.d. The draft of the specification says: image

But the tool is issuing a WARN for all values checked as part of 6.2.17.10.d that are greater than 0, in this case, I had a total of 95 incorrect WARNs on this test. Example below: image

Part 1 Bin 1 Value: image Part 2 Bin 1 Value: image

ericthomasswenson commented 1 year ago

Please post the Part 1 Bin 1 value too, Anthony, to fully establish the expected pass.

anthonyhbest commented 1 year ago

Attached are excerpts from the test log showing Bin 1 values, Bin 2 values and the associated WARN messages from the tool:

Issue1177_Part6-2-17-10-d_WARN.txt

ericthomasswenson commented 1 year ago

Errant comments deleted.

ericthomasswenson commented 1 year ago

In progress