search

Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

Adapters observed to send excess CTS responses #1188

Closed ericthomasswenson closed 1 year ago

ericthomasswenson commented 1 year ago

Selected adaptors have been observed to send excess CTS messages.

This results in data not being received within the observation.

Private data was provided to J1939-84@So…net for review.

The review findings and corrective actions are discussed by the provider below.

ericthomasswenson commented 1 year ago

On behalf of the provider who sent me:

[We] have a PEAK adapter and have started the evaluation. [We observe] duplicate CTS from the PEAK. This works with [one] ECM that [we have] been testing with and fails with another. [We] suspect that PEAK is using it's own J1939TP even though we have configured it to not be used. It may be because we sent the command to CMD_PROTECT_J1939_ADDRESS (handle the address claim in the adapter), so it assumes adapter TP support.

[We will] investigate putting address claiming functionality in the tool instead of using RP1210 adapter support. If that doesn't work, then instead of using J1939 mode, we will need to switch to raw CAN mode which will take quite a bit of effort, but I've done it before.

ericthomasswenson commented 1 year ago

The provider also reported:

Removing the CMD_PROTOECT_J1939_ADDRESS allows PEAK to work.
We will move the address claim logic to the application from the adapter.

ericthomasswenson commented 1 year ago

Address claim added to application layer. Not observed in 3.1.5