Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

Please clarify 6.2.8.2.e #1191

Closed ericthomasswenson closed 4 months ago

ericthomasswenson commented 2 years ago

Please clarify where the 6.2.8.2.e requirement "e. Fail if NACK not received from OBD ECUs that did not provide a DM26 response "to global query” actually belongs?

ericthomasswenson commented 2 years ago

It’s the same concept as 6.2.8.4 Fail Criteria2 a. Fail if any difference compared to data received from global request. b. Fail if NACK not received from OBD ECUs that did not respond to global query.

But the global and DS queries were purposefully transposed in test 6.2.8. Delete 6.2.8.2.e

6.2.8.2 Fail Criteria a. Fail if any response for each monitor not supported in DM5 by a given ECU from 6.2.2.3 is also reported in DM26 as “1=monitor not complete this monitoring cycle” in SP 3303 bits 5-7. // Unsupported monitors will never need to run and are ‘de facto’ complete.

b. Fail if any response for each monitor not supported in DM5 by a given ECU is also reported in DM26 as “0=monitor enabled for this monitoring cycle” in SP 3303 bits 1 and 2 and SP 3304. [

// Unsupported monitors will never run and cannot be enabled.

c. Fail if any response from an ECU indicating support for CCM monitor in DM5 reports “0=monitor disabled for rest of this cycle or not supported” in SP 3303 bit 3.

d. Fail if any ECU reports number of warm-ups SCC (SP 3302) greater than zero. [1]

e. Fail if NACK not received from OBD ECUs that did not provide a DM26 response to global query. // Delete 6.2.82.e.

[1] 13 CCR 1971.1 (c) (c. 2013) defines a warm-up cycle to require a 40 °F temperature rise in the engine coolant temperature. That is unlikely to occur in the time expected. Therefore, zero is the correct response.